[tor-bugs] #23577 [Core Tor/Tor]: Make setup_introduce1_data() take a node instead of an extend_info

[Tor Bug Tracker & Wiki]

#23577: Make setup_introduce1_data() take a node instead of an extend_info
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  prop224, tor-hs, single-onion, ipv6  |  Actual Points:
Parent ID:  #23493                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by neel):

 I am working on a new patch, but I have two questions:

 1. For the IPv6 check, I am making use of the function
 {{{link_specifier_set_un_ipv6_addr()}}}, and it has a parameter {{{size_t
 idx}}}. What is the {{{idx}}} parameter and what is it used for?
 2. I am introducing two new functions:
   a. {{{ curve25519_pubkey_eq()}}} in {{{src/common/crypto_curve25519.c}}}
 and {{{src/common/crypto_curve25519.h}}}
   b. {{{ node_get_curve25519_id()}}} in {{{src/or/nodelist.c}}} and
 {{{src/or/nodelist.h}}}
  Do I need to implement a regression test for these two functions?

 I hope you can respond in a timely manner.

 Best,

 Neel

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23577#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online