[tor-bugs] #23577 [Core Tor/Tor]: Make setup_introduce1_data() take a node instead of an extend_info

[Tor Bug Tracker & Wiki]

#23577: Make setup_introduce1_data() take a node instead of an extend_info
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  prop224, tor-hs, single-onion, ipv6  |  Actual Points:
Parent ID:  #23493                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 Thank you for the patch, Neel.

 Here's my review:

 Functionality

 The reason we want to make this change is that the node sometimes has an
 IPv6 address.
 If the node has an IPv6 address, we need to add it to the link specifiers.
 Then we can remove the existing (incorrect) comment:
 {{{XXX: IPv6 is not clearly a thing in extend_info_t?}}}

 On some clients and relays, nodes don't have a routerinfo (ri is NULL).
 So you need to use the accessor functions for the primary (IPv4) and IPv6
 addresses for the node, which do the right thing.
 I think they're called something like node_get_primary_orport and
 node_get_ipv6_orport.

 Testing

 Did you test this code before you submitted it?
 Do the unit tests (make test) need changes so they pass with these code
 changes?
 Does chutney work with these changes? (make test-network-all)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23577#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online