[tor-bugs] #23710 [Core Tor/Tor]: sched: channel_more_to_flush() is probably looking at the wrong queue

[Tor Bug Tracker & Wiki]

#23710: sched: channel_more_to_flush() is probably looking at the wrong queue
--------------------------+------------------------------------
 Reporter:  dgoulet       |          Owner:  (none)
     Type:  defect        |         Status:  new
 Priority:  High          |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  tor-sched     |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by dgoulet):

 Quick note: #23709 is a thing, the `incoming_queue` is always empty so it
 doesn't affect `channel_more_to_flush()` as it it basically always true
 that it is empty so it will never return 1 in the case of it being non
 empty.

 Thus, it is safe for now to leave it that way.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23710#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online