[tor-bugs] #23741 [Core Tor/Tor]: scripts/test/coverage tries to mv .gcov files to /

[Tor Bug Tracker & Wiki]

#23741: scripts/test/coverage tries to mv .gcov files to /
------------------------------+--------------------------------
     Reporter:  catalyst      |      Owner:  catalyst
         Type:  defect        |     Status:  assigned
     Priority:  Medium        |  Milestone:  Tor: 0.3.2.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  tor-tests-coverage
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 When run with no arguments, the `scripts/test/coverage` script attempts to
 move the .gcov files to the root directory.  This shouldn't happen.
 Hopefully most users won't run this script as a UID that has write access
 to the root directory, but we should fix this anyway.  Either exit with a
 usage error if there is no directory name argument, or change the test to
 `[ -d "$dst" ]`.  (The existing test, `[ -n $dst ]` with no quoting around
 `$dst`, returns true if `$dst` is empty on the macOS and Linux systems
 I've tried it on.  This surprising behavior is apparently required by
 POSIX.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23741>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online