[tor-bugs] #24119 [Core Tor/Tor]: channel_rsa_id_group_set_badness spends a lot of time in malloc/free

[Tor Bug Tracker & Wiki]

#24119: channel_rsa_id_group_set_badness spends a lot of time in malloc/free
-------------------------------------------------+-------------------------
 Reporter:  Hello71                              |          Owner:  Hello71
     Type:  enhancement                          |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Minor                                |     Resolution:
 Keywords:  tor-channel, tor-sched,              |  Actual Points:
  032-backport                                   |
Parent ID:  #23777                               |         Points:
 Reviewer:  isis                                 |        Sponsor:
                                                 |  Sponsor8-can
-------------------------------------------------+-------------------------

Comment (by Hello71):

 I think that would be correct if all callers ensure that either side
 channels are (effectively) unobservable, such as in these background
 tasks, or that the foreign party has proved that it owns the private key
 for this public key. the former doesn't apply everywhere, and the latter
 sounds nearly impossible to ensure.

 tl;dr lgtm, ignore part about ed25519_pubkey_eq in previous comment

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24119#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online