[tor-bugs] #24455 [Core Tor/Tor]: messages out of order in the tor log due to stored logs (was: clock tick backwards in the tor log)

[Tor Bug Tracker & Wiki]

#24455: messages out of order in the tor log due to stored logs
--------------------------+------------------------------------
 Reporter:  darkk         |          Owner:  (none)
     Type:  defect        |         Status:  new
 Priority:  Medium        |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  security-low  |  Actual Points:
Parent ID:                |         Points:  0.5
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by teor):

 * keywords:   => security-low
 * points:   => 0.5
 * milestone:  Tor: unspecified => Tor: 0.3.3.x-final


Comment:

 I think this is an artifact of our code that stores early logs, then loads
 the config, then opens a log file, and writes stored logs to this file.

 There are two potential bugs here:
 1. Should "Tor 0.2.7.6 opening new log file." come after the stored logs?
 (Probably not?)
 2. Should the times on the stored logs be rounded to the configured
 LogTimeGranularity, or should we choose a safer default for
 LogTimeGranularity?

 Let's think about this in 0.3.3, because LogTimeGranularity is meant to
 protect users, and it clearly isn't protecting the exact time they started
 Tor.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24455#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online