[tor-bugs] #24456 [Core Tor/Tor]: Figure out what to do with the guardfraction feature

[Tor Bug Tracker & Wiki]

#24456: Figure out what to do with the guardfraction feature
------------------------------------+------------------------------------
 Reporter:  asn                     |          Owner:  (none)
     Type:  defect                  |         Status:  new
 Priority:  Medium                  |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor            |        Version:
 Severity:  Normal                  |     Resolution:
 Keywords:  tor-dirauth, tor-guard  |  Actual Points:
Parent ID:                          |         Points:  2
 Reviewer:                          |        Sponsor:
------------------------------------+------------------------------------
Description changed by asn:

Old description:

> Guardraction code is still around the codebase:
> `guard_get_guardfraction_bandwidth()`, `should_apply_guardfraction()`,
> `routerstatus_parse_guardfraction()`, `guardfraction_line_apply()`,
> `guardfraction_file_parse_guard_line()`,
> `dirserv_read_guardfraction_file_from_str()`,
> `compute_weighted_bandwidths()`. Also AFAIK some dirauths are still
> running the guardfraction python script.
>
> Unfortunately, guardfraction code is still broken because of #16255 and
> possibly other unknown bugs. Hence, guardfraction support is disabled in
> the dirauths and all that code is currently useless.
>
> My current plan here is to remove the guardfraction code from the Tor
> codebase, since fixing it and maintaining it as a PITA that I don't want
> to sign up for and we probably don't need it as much as we thought we did
> (see ticket:16255:comment:36).

New description:

 Guardraction code is still around the codebase:
 `guard_get_guardfraction_bandwidth()`, `should_apply_guardfraction()`,
 `routerstatus_parse_guardfraction()`, `guardfraction_line_apply()`,
 `guardfraction_file_parse_guard_line()`,
 `dirserv_read_guardfraction_file_from_str()`,
 `compute_weighted_bandwidths()`. Also AFAIK some dirauths are still
 running the guardfraction python script.

 Unfortunately, guardfraction code is still broken because of #16255 and
 possibly other unknown bugs. Hence, guardfraction support is disabled in
 the dirauths and all that code is currently useless.

 My current plan here is to remove the guardfraction code from the Tor
 codebase, since fixing it and maintaining it as a PITA that I don't want
 to sign up for and we probably don't need it as much as we thought we did
 (see comment:36:ticket:16255).

--

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24456#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online