[tor-bugs] #24342 [Core Tor]: Various spec fixes to dir-spec, rend-spec-v3

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Nov 27 16:54:26 UTC 2017


#24342: Various spec fixes to dir-spec, rend-spec-v3
---------------------------------------+-----------------------------------
 Reporter:  filippo                    |          Owner:  (none)
     Type:  defect                     |         Status:  needs_revision
 Priority:  Medium                     |      Milestone:  Tor:
                                       |  0.3.3.x-final
Component:  Core Tor                   |        Version:
 Severity:  Normal                     |     Resolution:
 Keywords:  tor-spec, review-group-26  |  Actual Points:
Parent ID:                             |         Points:
 Reviewer:                             |        Sponsor:
---------------------------------------+-----------------------------------
Changes (by asn):

 * status:  merge_ready => needs_revision


Comment:

 Hello Filipo,

 many thanks for the detailed and intricate spec fixes!!! I like most of
 the prop224 fixes and I think they are well needed.

 One thing that I would like to improve: In `42e31d5`, we are introducing
 the `RH` and RH'` variables (which IIUC correspond to the extended secret
 key of ed25519 which is already a confusing subject), but we are not
 defining what they are and how they are used.

 I think we should probably motivate those two variables before introducing
 them in the spec because otherwise they complicate the spec without
 helping out the reader. I know this is not an easy task and it will
 probably make that section a bit more dirty, but I think it's The Right
 Thing to do since we are fixing that part of the spec.

 I'm marking this as `needs_revision` for the above comment, but please let
 me know if you disagree or if I'm mistaken, and we can move it back to
 `merge_ready`.

 Thanks!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24342#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list