[tor-bugs] #23709 [Core Tor/Tor]: channel: `outgoing_queue` and `incoming_queue` are always empty

[Tor Bug Tracker & Wiki]

#23709: channel: `outgoing_queue` and `incoming_queue` are always empty
--------------------------+------------------------------------
 Reporter:  dgoulet       |          Owner:  dgoulet
     Type:  defect        |         Status:  needs_review
 Priority:  High          |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  tor-sched     |  Actual Points:
Parent ID:  #23993        |         Points:
 Reviewer:                |        Sponsor:  SponsorV
--------------------------+------------------------------------
Changes (by dgoulet):

 * status:  accepted => needs_review


Comment:

 Ooook! This is pretty big but mostly code removal and new tests.

 Because the channel subsystem is quite critical to Tor, I've added a load
 of unit tests raising the coverage to `83.6%` for `channel.c`. More will
 be added as more things get fixed (like #23993).

 In order to pull off this queue removal, I had to cleanup many things for
 which I believe `channel.c` is now much nicer and simpler. A lot of dead
 or unused code has been removed as well as an attempt to simplify
 everything.

 This branch has been running for two days or so on my fast tor relay. So
 far, no memleaks nor issues I can see.

 This is the summary of `git diff --stat master`. The insertions are at
 least 95% of unit tests. All in all, this makes things simpler, more
 tested, better documented and one less abstraction on which the cells
 transit. Will help us greatly for the next step of cleanly separating
 `channel_t` and `channeltls_t`. One extra bonus point, I now understand
 that subsystem :).

 {{{
  11 files changed, 884 insertions(+), 2752 deletions(-)
 }}}

 Branch: `ticket23709_033_01`
 OnionGit: https://oniongit.eu/dgoulet/tor/merge_requests/11

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23709#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online