[tor-bugs] #24363 [Core Tor/Tor]: Remove /usr/athena from search path in configure.ac

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue Nov 21 15:47:49 UTC 2017


#24363: Remove /usr/athena from search path in configure.ac
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  (none)
     Type:  defect        |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by pastly):

 Thanks for the patch!

 I see you included a change file. That's awesome. Nick loves that.

 Are you aware of the ./script/maint/lintChanges.py script? Your changes
 file doesn't pass the script because "Minor change" isn't one of the known
 headings. Peeking at the source of the script, if it was me making this
 change and wanting to please the Tor ~~gods~~ maintainers, I'd probably
 use "Code simplification and refactoring"

 It still takes me about 3 attempts to please the script :). You call it
 like `./scripts/maint/lintChanges.py changes/ticket24363` and silence
 indicates success.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24363#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list