[tor-bugs] #23760 [Core Tor/Tor]: Use node_get_curve25519_onion_key() in extend_info_from_node()

[Tor Bug Tracker & Wiki]

#23760: Use node_get_curve25519_onion_key() in extend_info_from_node()
----------------------------+------------------------------------
 Reporter:  teor            |          Owner:  (none)
     Type:  enhancement     |         Status:  needs_revision
 Priority:  Medium          |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor    |        Version:
 Severity:  Normal          |     Resolution:
 Keywords:  refactor, easy  |  Actual Points:
Parent ID:                  |         Points:
 Reviewer:                  |        Sponsor:
----------------------------+------------------------------------

Comment (by teor):

 Hi,

 When I try to compile this, I get the following errors:
 {{{
 src/or/circuitbuild.c:2699:5: error: implicit declaration of function
       'node_get_curve25519_onion_key' is invalid in C99
       [-Werror,-Wimplicit-function-declaration]
     node_get_curve25519_onion_key(node);
     ^
 src/or/circuitbuild.c:2699:5: note: did you mean
       'node_has_curve25519_onion_key'?
 ./src/or/nodelist.h:78:5: note: 'node_has_curve25519_onion_key' declared
 here
 int node_has_curve25519_onion_key(const node_t *node);
     ^
 src/or/circuitbuild.c:2698:34: error: incompatible integer to pointer
 conversion
       initializing 'const curve25519_public_key_t *' (aka 'const struct
       curve25519_public_key_t *') with an expression of type 'int'
       [-Werror,-Wint-conversion]
   const curve25519_public_key_t *curve_pubkey =
                                  ^
 }}}

 Please import the correct header for node_get_curve25519_onion_key(), or
 put a declaration in the correct header.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23760#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online