[tor-bugs] #24337 [Core Tor/Tor]: Every _free() function should be a macro that sets the corresponding pointer to NULL.

Tue Nov 21 14:58:56 UTC 2017

#24337: Every _free() function should be a macro that sets the corresponding
pointer to NULL.
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  nickm
     Type:  enhancement   |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:  Sponsor8-can
--------------------------+------------------------------------

Comment (by nickm):

 Note to the reviewer: you are not expected to review the enormous machine-
 generated commits!  Instead I suggest that you re-run the perl scripts to
 verify that I really did generate those commits automatically, and then
 review the substitutions in those scripts to make sure that they look
 reasonable.  This should save you a lot of time.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24337#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online