[tor-bugs] #24099 [Core Tor/Tor]: tor should remove empty/invalid consensus cache files (Unable to map file from consensus cache: Numerical result out of range)

[Tor Bug Tracker & Wiki]

#24099: tor should remove empty/invalid consensus cache files (Unable to map file
from consensus cache: Numerical result out of range)
--------------------------+------------------------------------
 Reporter:  Hello71       |          Owner:  nickm
     Type:  defect        |         Status:  merge_ready
 Priority:  Low           |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Minor         |     Resolution:
 Keywords:  031-backport  |  Actual Points:
Parent ID:                |         Points:
 Reviewer:  ahf           |        Sponsor:
--------------------------+------------------------------------
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 `cabcb752d7ecc2d16e6cb630b3de0684b4f97ec5` looks good.

 As per discussion on IRC, in `c8ee12b2e8108658d647aedb92885311291b6f71`,
 it would be useful to have a comment in `consensus_cache_rescan()` about
 the meaning of `errno == ERANGE` after calling `tor_mmap_file()`.

 I think we are generally a bit inconsistent about this, but there is an
 empty line at the end of `changes/bug24099`, but it looks like that
 shouldn't really matter.

 Otherwise the patches look good.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24099#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online