[tor-bugs] #24346 [Core Tor/Tor]: prop224: Service stops uploading one of its two descriptors

[Tor Bug Tracker & Wiki]

#24346: prop224: Service stops uploading one of its two descriptors
-----------------------------+------------------------------------
 Reporter:  asn              |          Owner:  dgoulet
     Type:  defect           |         Status:  accepted
 Priority:  Medium           |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor     |        Version:  Tor: 0.3.2.4-alpha
 Severity:  Normal           |     Resolution:
 Keywords:  prop224, tor-hs  |  Actual Points:
Parent ID:                   |         Points:  2
 Reviewer:                   |        Sponsor:
-----------------------------+------------------------------------
Changes (by dgoulet):

 * status:  new => accepted
 * owner:  (none) => dgoulet
 * cc: dgoulet (removed)
 * keywords:  prop224 => prop224, tor-hs


Comment:

 Agree, I've looked at the logs and notice here, the next descriptor stops
 being uploaded:

 {{{
 Nov 16 21:30:21.000 [info] run_upload_descriptor_event(): Initiating
 upload for hidden service current descriptor for service onion with 3/3
 introduction points.
 Nov 16 22:49:34.000 [info] run_upload_descriptor_event(): Initiating
 upload for hidden service current descriptor for service onion with 3/3
 introduction points.
 Nov 17 00:23:30.000 [info] run_upload_descriptor_event(): Initiating
 upload for hidden service current descriptor for service onion with 3/3
 introduction points.
 Nov 17 01:08:16.000 [info] run_upload_descriptor_event(): Initiating
 upload for hidden service next descriptor for service onion with 5/3
 introduction points.
 }}}

 And then before 01:08:16, the current is discarded, the next is the new
 current (`current = next`) and we create a new next descriptor. So at that
 point, the current descriptor becomes the one never uploading and the next
 is fine because it is a brand new one. Interestingly enough, this pattern
 comes back hours later...

 I can't tell from the logs why this is happening so as suggested, we need
 to log every failing condition in `should_service_upload_descriptor()` so
 we can have more information on why it is deciding to not upload the
 descriptor...

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24346#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online