[tor-bugs] #18105 [Core Tor/Tor]: Replace getsockname with tor_getsockname

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Nov 20 09:29:15 UTC 2017

#18105: Replace getsockname with tor_getsockname
 Reporter:  teor                                 |          Owner:
                                                 |  eewayhsu
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  easy, intro, api, code-              |  Actual Points:
  simplification                                 |
Parent ID:                                       |         Points:  small
 Reviewer:                                       |        Sponsor:

Comment (by callumw):

 Thanks for the advice regarding the header files. I moved the function to
 address.c as you recommended and that resolved the issue.

 I have attached a new patch file with the new function implementation in.
 The first test under 'make check' fails but this behaviour can be
 replicated in a newly checkout-out repo so I assume it is unrelated to my
 changes here.

Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18105#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

More information about the tor-bugs mailing list