[tor-bugs] #23817 [Core Tor/Tor]: Tor re-tries directory mirrors that it knows are missing microdescriptors

[Tor Bug Tracker & Wiki]

#23817: Tor re-tries directory mirrors that it knows are missing microdescriptors
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.1.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-guard, tor-hs, prop224,          |  Actual Points:
  032-backport? 031-backport? spec-change        |
Parent ID:  #21969                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 The code looks good to me, and everything passes.

 I have added some questions to #24113 and #23863 about possible changes to
 this code when we do those tickets.

 I have one question that we should resolve before backporting to 0.3.1 or
 releasing 0.3.2:

 In should_set_md_dirserver_restriction(), what if we have more than 10
 filtered guards, but less than 10 of them are actually contactable or
 running?

 For example, this can happen with the default Tor Browser bridges if a
 client can only contact bridges over IPv6, but hasn't set any reachability
 options. (There are many Tor Browser bridges, but only one of them has
 IPv6.)

 (I can't remember if filtered guards are guaranteed to be running or not.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23817#comment:47>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online