[tor-bugs] #23114 [Core Tor/Tor]: Circuit Build Timeout should apply at circuit completion

[Tor Bug Tracker & Wiki]

#23114: Circuit Build Timeout should apply at circuit completion
-------------------------------------------------+-------------------------
 Reporter:  mikeperry                            |          Owner:
                                                 |  mikeperry
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  guard-discovery-prop247-controller,  |  Actual Points:
  review-group-25                                |
Parent ID:  #23100                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by mikeperry):

 * status:  needs_review => needs_revision


Comment:

 Hrmm.. I'm guessing that this branch is going to be annoying to review
 with the refactoring and changes in the same commit as well. I guess I
 will do the git juggling to break them apart...

 Sorry for all the git mess here. This ticket and #23100 really should have
 been just one ticket. Changing the same block of code in two tickets was
 really unwieldy. It means every fixup is automatically a conflict. Not to
 mention the unit test problem...

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23114#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online