[tor-bugs] #23817 [Core Tor/Tor]: Tor re-tries directory mirrors that it knows are missing microdescriptors

[Tor Bug Tracker & Wiki]

#23817: Tor re-tries directory mirrors that it knows are missing microdescriptors
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-guard, tor-hs, prop224,          |  Actual Points:
  032-backport? 031-backport? spec-change        |
Parent ID:  #21969                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by asn):

 * status:  needs_review => merge_ready


Comment:

 Replying to [comment:39 nickm]:
 > I've tried to implement the approach above in a branch
 `bug23817_032_asn_a`, based on your code.  In a different branch, called
 `bug23817_032_asn_b`, I've taken an approach that might be simpler, using
 existing functions.  Do you like one of those?

 I like your filtered approach Nick.

 I think I like (a) more than (b) because `num_reachable_filtered_guards()`
 tries to do a bit too many things at once (resets timeouts, and also only
 counts '''reachable filtered''' guards instead of just filtered). (a)
 seems simpler to understand.

 In (a) we can also constify the `entry_guard_t *` inside the smartlist
 loop. I tested it on the real net and on chutney `test-network-all` and
 seems to work well (and restrictions seem to apply correctly).

 Marking this as `merge_ready`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23817#comment:41>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online