[tor-bugs] #23100 [Core Tor/Tor]: Circuit Build Timeout needs to count hidden service circuits

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu Nov 16 11:30:29 UTC 2017

#23100: Circuit Build Timeout needs to count hidden service circuits
 Reporter:  mikeperry                            |          Owner:
                                                 |  mikeperry
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.7
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-hs, path-bias, guard-discovery-  |  Actual Points:
  prop247-controller, needs-proposal, mike-can,  |
  prop247, tor-guard, review-group-25            |
Parent ID:  #9001                                |         Points:
 Reviewer:  asn                                  |        Sponsor:
Changes (by asn):

 * status:  needs_review => needs_revision


 Hey Mike,

 I don't like the way this and #23114 are being developed. I'm trying to
 review your code and I feel like you are not respecting my efforts. I have
 asked you three times to decouple this from the #23114 branch and you have
 still not done it, and not only that but you are now
 [https://oniongit.eu/network/tor/merge_requests/5#note_1568 merging fixes]
 of #23100 into the #23114 commits... I think you are underestimating the
 time it takes me to review your code and you are making it much harder for
 me to ACK it. It took me '''more than a full day''' to work out the
 details of #23100 and it's gonna take me more time to do #23114, so by
 having those two branches together you are delaying the whole thing. I'd
 prefer to see #23100 get merged, before I jump into reviewing #23114, or
 maybe I'd even prefer if someone else reviewed #23114 since it's non-
 trivial amount of reviewing.

 I'm not familiar with the CBT code and reviewing it sure ain't easy, so
 please try to make it easy for me. Also decoupling tickets and branches
 from each other is standard procedure and it's how Tor development is
 being done.

 Or maybe I'm having a bad day :)


Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23100#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

More information about the tor-bugs mailing list