[tor-bugs] #20699 [Core Tor/Tor]: prop224: Add control port events and commands

[Tor Bug Tracker & Wiki]

#20699: prop224: Add control port events and commands
-------------------------------------------------+-------------------------
 Reporter:  dgoulet                              |          Owner:  dgoulet
     Type:  enhancement                          |         Status:
                                                 |  accepted
 Priority:  Very High                            |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-hs, needs-proposal,              |  Actual Points:
  prop224-extra, tor-control                     |
Parent ID:                                       |         Points:  6
 Reviewer:                                       |        Sponsor:
                                                 |  SponsorR-must
-------------------------------------------------+-------------------------

Comment (by asn):

 Replying to [comment:16 dgoulet]:
 > @asn, agree on `HSFETCH`, I think we should implement it on the "we need
 it" so we avoid bloating the control port with unused command.
 >
 > All in all, (1) we need to extend `HSPOST` to accept an onion address or
 a base64 encoded identity pk (not sure which one is ideal) and (2) I would
 think that only doing plaintext validation is enough which is what the
 HSDir will do anyway.
 >
 > See prop284 changes here: `ticket20699_02`
 >
 > Introduces the `HSAddress=` optional field. I went for the onion address
 instead of a base64 encoded identity pubkey. Now is a good time to make an
 argument for the base64 instead of the onion.

 I think I also prefer the onion address over the base64 encoded identity
 pubkey. It seems more natural to me, and something that more people are
 exposed to.

 Also I think it's fine to only do plaintext validation (aka the thing that
 HSDirs do).

 Onwards!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20699#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online