[tor-bugs] #23100 [Core Tor/Tor]: Circuit Build Timeout needs to count hidden service circuits

[Tor Bug Tracker & Wiki]

#23100: Circuit Build Timeout needs to count hidden service circuits
-------------------------------------------------+-------------------------
 Reporter:  mikeperry                            |          Owner:
                                                 |  mikeperry
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.7
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-hs, path-bias, guard-discovery-  |  Actual Points:
  prop247-controller, needs-proposal, mike-can,  |
  prop247, tor-guard, review-group-25            |
Parent ID:  #9001                                |         Points:
 Reviewer:  asn                                  |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by mikeperry):

 * status:  needs_revision => needs_review


Comment:

 Ok. I pushed fixups for all of asn's comments. We also had some discussion
 about refactoring, so I did that in the commit for #23114.

 I prefer this and the child ticket (#23114) to be merged together, since
 the tests were written to cover both. The new merge request is
 https://oniongit.eu/network/tor/merge_requests/6.

 The old branch with all of the fixups is still bugs23100+23114-cleanup-
 squashed. The new one is bugs23100+23114-cleanup-squashed2. Both heads are
 identical.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23100#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online