[tor-bugs] #24174 [Metrics/ExoneraTor]: Use an embedded Jetty in ExoneraTor

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Nov 13 20:25:32 UTC 2017

#24174: Use an embedded Jetty in ExoneraTor
 Reporter:  iwakeh              |          Owner:  iwakeh
     Type:  enhancement         |         Status:  needs_revision
 Priority:  Medium              |      Milestone:
Component:  Metrics/ExoneraTor  |        Version:
 Severity:  Normal              |     Resolution:
 Keywords:  metrics-2017        |  Actual Points:
Parent ID:                      |         Points:
 Reviewer:                      |        Sponsor:
Changes (by karsten):

 * status:  needs_review => needs_revision


 Looks good and works locally! Some comments/questions:

  - Can we use `metrics` and `password` as defaults in
 `src/main/resources/jetty.xml`? That should be as simple as writing
 `<SystemProperty name="exonerator.db.user" default="metrics"/ >` and
 `<SystemProperty name="exonerator.db.pw" default="password"/ >`. Just in
 case somebody uses those defaults locally for testing, that is.

  - Is there a particular reason why you suggest bumping to 2.0.0 and not
 1.1.0? For the Java 8 update we also made a minor version bump. Nothing
 backward-incompatible going on here, right?

  - Out of curiousity, what's the full command line that you're using to
 start the JAR and the WAR file? Mine is pretty long, and I'm curious
 whether that's just for me or for everyone. Maybe we can start thinking
 about configuration libraries (#24041) after this ticket?

 I'll merge tomorrow after the first two questions are resolved. Setting to
 needs_revision only for these trivial tweaks.

 And unless there are any reason not to deploy, I'd do that shortly after.

Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24174#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

More information about the tor-bugs mailing list