[tor-bugs] #24230 [Core Tor/Tor]: control: HS_DESC event failed upload sends back the wrong Action

[Tor Bug Tracker & Wiki]

#24230: control: HS_DESC event failed upload sends back the wrong Action
---------------------------------------+-----------------------------------
 Reporter:  dgoulet                    |          Owner:  dgoulet
     Type:  defect                     |         Status:  needs_review
 Priority:  Medium                     |      Milestone:  Tor:
                                       |  0.3.2.x-final
Component:  Core Tor/Tor               |        Version:
 Severity:  Normal                     |     Resolution:
 Keywords:  easy, tor-control, tor-hs  |  Actual Points:
Parent ID:                             |         Points:
 Reviewer:                             |        Sponsor:
---------------------------------------+-----------------------------------

Comment (by dgoulet):

 Replying to [comment:4 nickm]:
 > What I'm wondering is, should we change the spec to match the code
 instead?

 I'm worried about that because Stem is implemented the way the spec does
 it, not the code. So right now, Stem will never pick up a failed upload
 event.

 And I can only imagine that other control port library are also doing the
 same. So, updating the code just seems more straight forward. Second, this
 would mean adding a new `Action` to the control spec which is a bit more
 work and nullifying a `Reason` that is used with the Action=Failed.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24230#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online