[tor-bugs] #23100 [Core Tor/Tor]: Circuit Build Timeout needs to count hidden service circuits

Tor Bug Tracker & Wiki blackhole at torproject.org
Sat Nov 11 01:18:51 UTC 2017


#23100: Circuit Build Timeout needs to count hidden service circuits
-------------------------------------------------+-------------------------
 Reporter:  mikeperry                            |          Owner:
                                                 |  mikeperry
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.7
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-hs, path-bias, guard-discovery-  |  Actual Points:
  prop247-controller, needs-proposal, mike-can,  |
  prop247, tor-guard, review-group-25            |
Parent ID:  #9001                                |         Points:
 Reviewer:  asn                                  |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by asn):

 Replying to [comment:15 mikeperry]:
 > Replied on gitlab. As for testability, there is a separate testing
 commit that tests the new functionality. Based on your gitlab comments, it
 sounded like you didn't see it? It tests one of the functions you asked
 for tests for.

 Thanks for the quick replies. I only looked at `42e4b3e18` since I thought
 that this was the commit for this ticket. As I said in #23114, I'm not
 used to a single branch for multiple tickets. I will review the extra
 commit and also reply to the gitlab comments next week.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23100#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list