[tor-bugs] #24169 [Core Tor/Tor]: When all consensus bandwidths are zero, should Tor still respect bandwidth weights?

[Tor Bug Tracker & Wiki]

#24169: When all consensus bandwidths are zero, should Tor still respect bandwidth
weights?
------------------------------+--------------------------------
     Reporter:  teor          |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.3.3.x-final
    Component:  Core Tor/Tor  |    Version:  Tor: 0.2.4.3-alpha
     Severity:  Normal        |   Keywords:  tor-client
Actual Points:                |  Parent ID:
       Points:  2             |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 In test networks with all-zero bandwidths, Tor chooses nodes uniformly at
 random. Instead, Tor should probably respect the bandwidth weights for
 guards, middles and exits.

 We could do this by modifying smartlist_choose_node_by_bandwidth_weights()
 and compute_weighted_bandwidths() to act as if all bandwidth weights are N
 rather than zero. N should be chosen so that typical bandwidth weights are
 preserved (typical weights in this case are 1, 1/3, and 0). So let's
 choose 30000, like the existing non-bandwidth code.

 Split off #23318.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24169>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online