[tor-bugs] #23817 [Core Tor/Tor]: Tor re-tries directory mirrors that it knows are missing microdescriptors

[Tor Bug Tracker & Wiki]

#23817: Tor re-tries directory mirrors that it knows are missing microdescriptors
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-guard, tor-hs, prop224,          |  Actual Points:
  032-backport? 031-backport?                    |
Parent ID:  #21969                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by asn):

 * status:  new => needs_review


Comment:

 Hello. I pushed my branch at `bug23817` in my repo.

 Some info:

 - It's a basic failure cache that works in the most basic way: If a
 dirserver fails to serve an md, we blacklist it until we get a new
 consensus and skip it. Is this too harsh?
 - We don't do this for bridges because we might have only one dirserv
 basically.
 - We log a warn if the list grows more than 30 elements long because of
 comment:12.

 The code is pretty clean I think and includes a unittest.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23817#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online