[tor-bugs] #24150 [Core Tor/Tor]: Memory leak in v3 hsdesc parsing with empty encrypted data.

[Tor Bug Tracker & Wiki]

#24150: Memory leak in v3 hsdesc parsing with empty encrypted data.
---------------------------------+------------------------------------
 Reporter:  nickm                |          Owner:  nickm
     Type:  defect               |         Status:  needs_revision
 Priority:  Medium               |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor         |        Version:
 Severity:  Normal               |     Resolution:
 Keywords:  tor-hs, memory-leak  |  Actual Points:
Parent ID:                       |         Points:
 Reviewer:                       |        Sponsor:
---------------------------------+------------------------------------
Changes (by dgoulet):

 * status:  needs_review => needs_revision


Comment:

 The check with `encrypted_data_length_is_valid()` and
 `tor_assert(encrypted_len > 0);` at the start of the function can't allow
 `encrypted_len` to be equal to 0.

 Did you meant `if (result_len == 0)` instead?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24150#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online