[tor-bugs] #18105 [Core Tor/Tor]: Replace getsockname with tor_getsockname

Tor Bug Tracker & Wiki blackhole at torproject.org
Sat Nov 4 17:28:10 UTC 2017


#18105: Replace getsockname with tor_getsockname
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:
                                                 |  eewayhsu
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  easy, intro, api, code-              |  Actual Points:
  simplification                                 |
Parent ID:                                       |         Points:  small
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by callumw):

 Replying to [comment:14 nickm]:
 > The idea would be to have a new, different function that only outputs
 the tor_addr_t -- not the sockaddr or the address_len.

 So would we want to pass the sockaddr and address_len by value instead of
 by reference? Otherwise I do not know another way to derive the
 tor_addr_t.

 Cheers

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18105#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list