[tor-bugs] #21031 [Core Tor/Tor]: Please don't remove ClientDNSRejectInternalAddresses

[Tor Bug Tracker & Wiki]

#21031: Please don't remove ClientDNSRejectInternalAddresses
-----------------------------+------------------------------------
 Reporter:  Sebastian        |          Owner:  Sebastian
     Type:  defect           |         Status:  needs_review
 Priority:  Medium           |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor     |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  review-group-23  |  Actual Points:  .1
Parent ID:                   |         Points:  .5
 Reviewer:  dgoulet          |        Sponsor:
-----------------------------+------------------------------------

Comment (by nickm):

 I've figured out how to fix the tests, but I'm not convinced this should
 be necessary:
 {{{
 diff --git a/src/test/test_options.c b/src/test/test_options.c
 index c55be358451192..6bc692d009cffb 100644
 --- a/src/test/test_options.c
 +++ b/src/test/test_options.c
 @@ -402,7 +402,8 @@ fixed_get_uname(void)
    "VirtualAddrNetworkIPv4 127.192.0.0/10\n"                             \
    "VirtualAddrNetworkIPv6 [FE80::]/10\n"                                \
    "UseEntryGuards 1\n"                                                  \
 -  "Schedulers Vanilla\n"
 +  "Schedulers Vanilla\n"                                                \
 +  "ClientDNSRejectInternalAddresses 1\n"

  typedef struct {
    or_options_t *old_opt;
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21031#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online