[tor-bugs] #24110 [Core Tor/Tor]: NS_CONTROL_PORT formats change when using microdescriptors

[Tor Bug Tracker & Wiki]

#24110: NS_CONTROL_PORT formats change when using microdescriptors
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.0.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  bwauth-needs, tor-control, tor-spec  |  Actual Points:
Parent ID:                                       |         Points:  1
 Reviewer:                                       |        Sponsor:
                                                 |  SponsorV-can
-------------------------------------------------+-------------------------

Comment (by atagar):

 Here's where the stem code around this came from. I thought this was an
 intentional change in tor...

 https://gitweb.torproject.org/stem.git/commit/?id=d70fa9cd

 However, catalyst made the great point on irc that this code actually
 doesn't get invoked in practice nowadays because UseMicrodescriptors
 defaults to 'auto' rather than '1'. I just checked and stem indeed
 provides back standard RSEs rather than the microdescriptor version...

 {{{
 % tor-prompt
 >>> import pprint
 >>> desc = next(controller.get_network_statuses())
 >>> type(desc)
 <class 'stem.descriptor.router_status_entry.RouterStatusEntryV3'>

 >>> pprint.pprint(desc.__dict__)
 {'_archive_path': None,
  '_entries': {},
  '_lazy_loading': False,
  '_path': None,
  '_raw_contents': 'r networkofthesmoker AAaX5kASI9/xzl9Qp7aFdPOSnrQ
 aoqBoLrUWKssJAKnO8r6GpZs5p8 2017-11-02 13:51:59 128.72.180.74 443 0\ns
 Fast Guard HSDir Running Stable V2Dir Valid\nw Bandwidth=4150\n',
  '_unrecognized_lines': [],
  'address': u'128.72.180.74',
  'bandwidth': 4150,
  'digest': '6A8A81A0BAD458AB2C2402A73BCAFA1A966CE69F',
  'dir_port': None,
  'document': None,
  'fingerprint': '000697E6401223DFF1CE5F50A7B68574F3929EB4',
  'flags': [u'Fast',
            u'Guard',
            u'HSDir',
            u'Running',
            u'Stable',
            u'V2Dir',
            u'Valid'],
  'is_unmeasured': False,
  'measured': None,
  'nickname': u'networkofthesmoker',
  'or_port': 443,
  'published': datetime.datetime(2017, 11, 2, 13, 51, 59),
  'unrecognized_bandwidth_entries': []}
 }}}

 This makes me kinda tempted to drop the check in stem...

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24110#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online