[tor-bugs] #21145 [Metrics/ExoneraTor]: Adapt ExoneraTor to using metrics-base

[Tor Bug Tracker & Wiki]

#21145: Adapt ExoneraTor to using metrics-base
--------------------------------+------------------------------
 Reporter:  iwakeh              |          Owner:  iwakeh
     Type:  enhancement         |         Status:  needs_review
 Priority:  Medium              |      Milestone:
Component:  Metrics/ExoneraTor  |        Version:
 Severity:  Normal              |     Resolution:
 Keywords:  metrics-2017        |  Actual Points:
Parent ID:                      |         Points:
 Reviewer:                      |        Sponsor:
--------------------------------+------------------------------

Comment (by karsten):

 Works! Pushed the metrics-base commit.

 But before I squash and push the ExoneraTor commits, did you make the
 following change on purpose?

 {{{
 -    <include name="postgresql-9.4.1212.jar"/>
 +    <include name="postgresql-jdbc3.jar"/>
 }}}

 I know that Debian stretch ships the JAR file as `postgresql.jar` together
 with three symbolic links:

 {{{
 lrwxrwxrwx 1 root root     14 Jan  9  2017
 /usr/share/java/postgresql-9.4.1212.jar -> postgresql.jar
 -rw-r--r-- 1 root root 650839 Jan  9  2017 /usr/share/java/postgresql.jar
 lrwxrwxrwx 1 root root     14 Jan  9  2017 /usr/share/java/postgresql-
 jdbc3.jar -> postgresql.jar
 lrwxrwxrwx 1 root root     14 Jan  9  2017 /usr/share/java/postgresql-
 jdbc4.jar -> postgresql.jar
 }}}

 But why pick the JDBC 3 link here rather than the one with the version
 number? That's different from what we do elsewhere.

 If this change just slipped in, I'll undo it and merge the rest.

 But if you intended to make this change, let's first discuss what names we
 should be using in build files in all metrics code bases.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21145#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online