[tor-bugs] #23900 [Core Tor/Tor]: Let programs call tor_main with a preconstructed control socket

[Tor Bug Tracker & Wiki]

#23900: Let programs call tor_main with a preconstructed control socket
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  nickm
     Type:  enhancement                          |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-mobile, review-group-24, s8-api  |  Actual Points:
Parent ID:  #23684                               |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor8
-------------------------------------------------+-------------------------

Comment (by hellais):

 sbs and I looked at this.

 The torspec and tor diffs look good.

 One thing to be careful about though is that when the socket is closed (as
 per TAKEOWNERSHIP behavior), when you "shut down" Tor, you must not call
 `exit()`.
 This may be differ from how `OwningControllerProcess` behaves.

 Moreover lack of windows support may be an issue for us (as that is also a
 target platform for Measurement Kit), but I guess for the time being we
 can avoid using this option there.

 Also as mentioned in
 https://trac.torproject.org/projects/tor/ticket/23845#comment:12, it would
 be useful to document that for non windows platforms it's recommended to
 set this option when constructing a `tor_main_configuration_t` to pass to
 `tor_run_main`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23900#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online