[tor-bugs] #22398 [Applications/Tor Browser]: Upgrade Go to 1.7.6 / 1.8.3

[Tor Bug Tracker & Wiki]

#22398: Upgrade Go to 1.7.6 / 1.8.3
----------------------------------------------+----------------------------
 Reporter:  yawning                           |          Owner:  tbb-team
     Type:  task                              |         Status:
                                              |  needs_review
 Priority:  Medium                            |      Milestone:
Component:  Applications/Tor Browser          |        Version:
 Severity:  Normal                            |     Resolution:
 Keywords:  tbb-gitian TorBrowserTeam201705R  |  Actual Points:
Parent ID:                                    |         Points:
 Reviewer:                                    |        Sponsor:
----------------------------------------------+----------------------------

Comment (by dcf):

 I am having problems building off of master
 ([https://gitweb.torproject.org/builders/tor-browser-
 bundle.git/log/?id=082738a4bd83943d97e084fa04045e481772b998 082738a4bd])
 that do not appear to be related to the Go upgrade, so I'll leave the
 patch here so you can try it.
 * attachment:0001-Bug-22398-Upgrade-go-to-1.8.3.patch

 Trying to build stable, I get an error in `make prep`:
 {{{
 $ make TORSOCKS=
 ...
 File ‘libcxxabi-3.8.0.src.tar.xz.sig’ not modified on server. Omitting
 download.

 ./fetch-inputs.sh: line 125: !PACKAGE: unbound variable
 Makefile:93: recipe for target 'prep' failed
 make: *** [prep] Error 1
 }}}

 Trying to build alpha, the build gets a lot farther, but fails while doing
 the system upgrade in `--- Building sandbox-linux for jessie amd64 ---`.
 {{{
 $ make resume-alpha TORSOCKS=
 ...
 Updating apt-get repository (log in var/install.log)
 Installing additional packages (log in var/install.log)
 Upgrading system, may take a while
 ./bin/gbuild:21:in `system!': failed to run on-target -u root bash <
 target-bin/upgrade-system.sh > var/install.log 2>&1 (RuntimeError)
         from ./bin/gbuild:112:in `build_one_configuration'
         from ./bin/gbuild:289:in `block (2 levels) in <main>'
         from ./bin/gbuild:284:in `each'
         from ./bin/gbuild:284:in `block in <main>'
         from ./bin/gbuild:282:in `each'
         from ./bin/gbuild:282:in `<main>'
 Makefile:27: recipe for target 'build-alpha' failed
 make: *** [build-alpha] Error 1
 }}}
 If I set the `-x` flag in target-bin/upgrade-system.sh to get some
 debugging output, I see an error relating to a missing /usr/sbin/update-
 grub:
 {{{
 $ ssh -o NoHostAuthenticationForLocalhost=yes root at 127.0.0.1 -p 2223 -i
 var/id_rsa < target-bin/upgrade-system.sh
 Pseudo-terminal will not be allocated because stdin is not a terminal.

 The programs included with the Debian GNU/Linux system are free software;
 the exact distribution terms for each program are described in the
 individual files in /usr/share/doc/*/copyright.

 Debian GNU/Linux comes with ABSOLUTELY NO WARRANTY, to the extent
 permitted by applicable law.
 stdin: is not a tty
 + mkdir -p /var/cache/gitian
 + apt-get -q -y purge grub
 + true
 + DEBIAN_FRONTEND=noninteractive
 + apt-get -y dist-upgrade
 Reading package lists...
 Building dependency tree...
 Reading state information...
 The following packages were automatically installed and are no longer
 required:
   bcron fgetty grub-common lib32ncurses5 lib32tinfo5 libbg1 libbg1-doc
   libc6-i386 libfuse2 os-prober runit ucspi-unix
 Use 'apt-get autoremove' to remove them.
 perl: warning: Setting locale failed.
 perl: warning: Please check that your locale settings:
         LANGUAGE = (unset),
         LC_ALL = (unset),
         LANG = "en_US.UTF-8"
     are supported and installed on your system.
 perl: warning: Falling back to the standard locale ("C").
 locale: Cannot set LC_CTYPE to default locale: No such file or directory
 locale: Cannot set LC_MESSAGES to default locale: No such file or
 directory
 locale: Cannot set LC_ALL to default locale: No such file or directory
 0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
 1 not fully installed or removed.
 After this operation, 0 B of additional disk space will be used.
 Setting up linux-image-3.16.0-4-amd64 (3.16.43-2) ...
 locale: Cannot set LC_CTYPE to default locale: No such file or directory
 locale: Cannot set LC_MESSAGES to default locale: No such file or
 directory
 locale: Cannot set LC_ALL to default locale: No such file or directory
 Running /usr/sbin/update-grub.
 Can't exec "/usr/sbin/update-grub": No such file or directory at
 /var/lib/dpkg/info/linux-image-3.16.0-4-amd64.postinst line 604.
 User postinst hook script [/usr/sbin/update-grub] failed to execute: No
 such file or directory
 dpkg: error processing package linux-image-3.16.0-4-amd64 (--configure):
  subprocess installed post-installation script returned error exit status
 255
 Errors were encountered while processing:
  linux-image-3.16.0-4-amd64
 E: Sub-process /usr/bin/dpkg returned an error code (1)
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22398#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online