[tor-bugs] #22415 [Applications/Tor Browser]: Format error in our pipeline patch

Tor Bug Tracker & Wiki blackhole at torproject.org
Sat May 27 15:47:24 UTC 2017


#22415: Format error in our pipeline patch
--------------------------------------+------------------------------
 Reporter:  arthuredelstein           |          Owner:  tbb-team
     Type:  defect                    |         Status:  needs_review
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  TorBrowserTeam201705R     |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+------------------------------
Changes (by arthuredelstein):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:4 yawning]:
 > NACK. Use `PRIu64` from `inttypes.h`, your patch assumes LP64 and is
 broken on Windows, which uses LLP64.

 Ouch, you are right:
 https://github.com/arthuredelstein/tor-browser/commit/22415+1

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22415#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list