[tor-bugs] #22410 [Core Tor/Tor]: ensure that uint8_t is unsigned char

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri May 26 23:03:13 UTC 2017


#22410: ensure that uint8_t is unsigned char
--------------------------+------------------------------------
 Reporter:  catalyst      |          Owner:  catalyst
     Type:  defect        |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:  #6877         |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by cypherpunks):

 This ticket seems to be trying to test whether two data types are actually
 the same. IMO this is the wrong approach to reach the goal of replacing
 the data type of some buffers.

 Instead the code should be designed and changed around the new data type
 and not simply swap data types after verifying they're the same.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22410#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list