[tor-bugs] #17750 [Core Tor/Tor]: Make bootstrapping clients wait before trying an authority (was: A download_status_t can be used before calling download_status_reset on it)

[Tor Bug Tracker & Wiki]

#17750: Make bootstrapping clients wait before trying an authority
---------------------------+------------------------------------
 Reporter:  teor           |          Owner:
     Type:  enhancement    |         Status:  needs_review
 Priority:  Medium         |      Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor   |        Version:  Tor: 0.2.8.1-alpha
 Severity:  Normal         |     Resolution:
 Keywords:  tor-bootstrap  |  Actual Points:  0.3
Parent ID:                 |         Points:  2
 Reviewer:                 |        Sponsor:
---------------------------+------------------------------------
Changes (by teor):

 * status:  new => needs_review
 * actualpoints:   => 0.3
 * version:   => Tor: 0.2.8.1-alpha
 * milestone:  Tor: unspecified => Tor: 0.3.1.x-final
 * keywords:  easy, review => tor-bootstrap


Comment:

 This bug means that bootstrapping clients an authority and a fallback
 immediately, and then try another fallback 1-3 seconds later, and another
 4-9 seconds after that. The intention was to try an authority after we'd
 tried the first 2-3 fallbacks.

 (arma discovered this was happening in #22400.)

 Please see my branch bug17750_029 for a general fix for this.
 It could go all the way back to 0.2.9 if we wanted it to, but we should
 definitely test it in master first.

 This bug could only ever have affected
 ClientBootstrapConsensusAuthorityDownloadSchedule and
 TestingBridgeDownloadSchedule, because every other schedule starts with 0
 (the default).

 And TestingBridgeDownloadSchedule is already initialised correctly.

 I opened #22403 as a follow up for those cases where we directly access a
 download_status_t's fields rather than using an accessor function.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17750#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online