[tor-bugs] #22327 [Applications/Tor Browser]: First party isolation of Page Info

[Tor Bug Tracker & Wiki]

#22327: First party isolation of Page Info
------------------------------------------------+--------------------------
 Reporter:  arthuredelstein                     |          Owner:  tbb-team
     Type:  defect                              |         Status:
                                                |  needs_review
 Priority:  Medium                              |      Milestone:
Component:  Applications/Tor Browser            |        Version:
 Severity:  Normal                              |     Resolution:
 Keywords:  tbb-7.0-must TorBrowserTeam201705R  |  Actual Points:
Parent ID:                                      |         Points:
 Reviewer:                                      |        Sponsor:
------------------------------------------------+--------------------------

Comment (by mcs):

 Kathy and I reviewed the changes and they look okay to us. But since we
 are not very familiar with the new way of doing isolation, we applied the
 patches and tried to run the revised code. Unfortunately, at least with
 our OSX debug build, invoking page info (Cmd+I) always causes an assertion
 failure:
 {{{
 Assertion failure: pb == (doa.mPrivateBrowsingId > 0), at /.../tor-
 browser/netwerk/base/LoadContextInfo.cpp:147
 }}}

 To make things more challenging, my lldb seems to have forgotten how to
 use symbols. I am not sure if we should be concerned about the assertion
 failure or not, but we will try again with an optimized build.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22327#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online