[tor-bugs] #22327 [Applications/Tor Browser]: First party isolation of Page Info

[Tor Bug Tracker & Wiki]

#22327: First party isolation of Page Info
------------------------------------------------+--------------------------
 Reporter:  arthuredelstein                     |          Owner:  tbb-team
     Type:  defect                              |         Status:
                                                |  needs_information
 Priority:  Medium                              |      Milestone:
Component:  Applications/Tor Browser            |        Version:
 Severity:  Normal                              |     Resolution:
 Keywords:  tbb-7.0-must TorBrowserTeam201705R  |  Actual Points:
Parent ID:                                      |         Points:
 Reviewer:                                      |        Sponsor:
------------------------------------------------+--------------------------

Comment (by arthuredelstein):

 Replying to [comment:3 gk]:
 > Replying to [comment:2 gk]:
 > > Hm, looking at that branch it seems we need
 32287fdd336a9ed2bbd52e71595fcb7e61394dc5 as well? Or am I missing
 something?

 Yes, sorry, I should have also mentioned that I backported that patch.

 > It seems you are missing the
 > {{{
 > +#include "nsSerializationHelper.h"
 > }}}
 > in that backported patch? I somehow doubt it would compile without it
 looking at the code.

 You're right. The branch builds, but the #include line somehow migrated
 from Ehsan's patch onto my patch. I have put it back into his patch and I
 have rebased the two patches onto the latest tor-browser-52.1.1esr-7.0-1
 branch. Here is the new result:
 https://github.com/arthuredelstein/tor-browser/commits/22327+1

 I rebuilt this new branch and ran the following manual test:

 1. add torbutton
 2. set extensions.torbutton.loglevel to 3
 3. open the Browser Console
 4. visit http://html5demo.com/video
 5. open Page Info
 6. observe "tor SOCKS" messages in the Browser Console

 When I ran this test, videos and images in the "media preview" box were
 correctly isolated to the content document's first party.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22327#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online