[tor-bugs] #21766 [Applications/Tor Browser]: Tor Browser based on ESR52 with e10s enabled crashed while trying to download a file

[Tor Bug Tracker & Wiki]

#21766: Tor Browser based on ESR52 with e10s enabled crashed while trying to
download a file
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  mcs
     Type:  defect                               |         Status:
                                                 |  needs_information
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Critical                             |     Resolution:
 Keywords:  ff52-esr, tbb-e10s, tbb-crash,       |  Actual Points:
  TorBrowserTeam201705R, tbb-7.0-must            |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor4
-------------------------------------------------+-------------------------

Comment (by mcs):

 Replying to [comment:42 gk]:
 > Another thought: Do we care about FTP downloads? It seems your patch
 does not address those but they are affected as well (just tested with
 ftp://ftp.gnu.org/gnu/gcc/). Leaving this ticket open for that question
 for now. We can solve this in a fixup commit if needed.

 I think we should care about FTP, at least a little. So far I cannot
 connect to ftp://ftp.gnu.org/gnu/gcc/ over Tor (I consistently get a "425
 Bad IP Connecting" error).  Kathy and I did test the patch last week with
 a large FTP download (ftp://speedtest.tele2.net/50MB.zip).  Aside from
 sometimes getting a "Bad IP" error with that server as well, it worked
 okay.  But I just tried with a small file
 (ftp://speedtest.tele2.net/1KB.zip) and got an assertion failure while
 running a debug build on OSX:
 {{{
 Assertion failure: ((bool)(__builtin_expect(!!(!NS_FAILED_impl(rv)), 1)))
 || rv == NS_ERROR_NOT_AVAILABLE, at
 /.../netwerk/protocol/ftp/FTPChannelParent.cpp:646
 #01:
 mozilla::net::FTPChannelParent::SuspendForDiversion()[/Users/.../Desktop/tb.app/Contents/MacOS/XUL
 +0x80503e]
 ...
 }}}

 We will need to debug this. Georg, what behavior do you see?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21766#comment:43>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online