[tor-bugs] #22267 [Applications/Tor Browser]: Windows build of esr52 Tor Browser has no DEP/ASLR

[Tor Bug Tracker & Wiki]

#22267: Windows build of esr52 Tor Browser has no DEP/ASLR
-------------------------------------------------+-------------------------
 Reporter:  boklm                                |          Owner:  boklm
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  TorBrowserTeam201705R, tbb-          |  Actual Points:
  security, ff52-esr, tbb-7.0-must               |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by boklm):

 * keywords:  TorBrowserTeam201705, tbb-security, ff52-esr, tbb-7.0-must =>
     TorBrowserTeam201705R, tbb-security, ff52-esr, tbb-7.0-must
 * status:  new => needs_review


Comment:

 In `gitian/descriptors/windows/gitian-firefox.yml` we are adding the
 hardened wrappers to the PATH before the build, but after running the
 configure script. It seems that in ESR52, the compiler that is used during
 the build is the one that was in the PATH when the configure script was
 run.

 I created a patch in the branch `bug_22267` to fix that, adding the
 wrappers before running the configure script:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 bundle.git/commit/?h=bug_22267

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22267#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online