[tor-bugs] #21766 [Applications/Tor Browser]: Tor Browser based on ESR52 with e10s enabled crashed while trying to download a file
Tor Bug Tracker & Wiki
blackhole at torproject.org
Fri May 19 09:25:13 UTC 2017
#21766: Tor Browser based on ESR52 with e10s enabled crashed while trying to
download a file
-------------------------------------------------+-------------------------
Reporter: gk | Owner: mcs
Type: defect | Status:
| needs_review
Priority: Very High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Critical | Resolution:
Keywords: ff52-esr, tbb-e10s, tbb-crash, | Actual Points:
TorBrowserTeam201705R, tbb-7.0-must |
Parent ID: | Points:
Reviewer: | Sponsor:
| Sponsor4
-------------------------------------------------+-------------------------
Comment (by gk):
Replying to [comment:38 mcs]:
> Kathy and I intended to ignore failures when calling `Suspend()` and
`Resume()`. We had the `rv =` there to make debugging easier, so we will
try using `Unused <<`.
>
> I think we should add restore the `NS_ENSURE_SUCCESS(rv, rv);` after the
call to `shouldCance()` though; that was removed by mistake.
Both sounds good to me. Do we understand why your previous patch
(`bug21766-01`) was not enough?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21766#comment:39>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list