[tor-bugs] #21953 [Core Tor/Tor]: Dealing with Tor hardening on Windows properly

[Tor Bug Tracker & Wiki]

#21953: Dealing with Tor hardening on Windows properly
---------------------------------------+-----------------------------------
 Reporter:  cypherpunks                |          Owner:
     Type:  defect                     |         Status:  needs_revision
 Priority:  Medium                     |      Milestone:  Tor:
                                       |  0.3.1.x-final
Component:  Core Tor/Tor               |        Version:
 Severity:  Normal                     |     Resolution:
 Keywords:  030-backport 029-backport  |  Actual Points:
Parent ID:                             |         Points:  0.1
 Reviewer:                             |        Sponsor:
---------------------------------------+-----------------------------------
Changes (by teor):

 * status:  merge_ready => needs_revision
 * milestone:  Tor: 0.3.0.x-final => Tor: 0.3.1.x-final


Comment:

 This breaks our jenkins Windows builder with:
 {{{
 gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I../tor  -I../tor/src/ext -Isrc/ext
 -I../tor/src/ext/trunnel -I../tor/src/trunnel -I../tor/src/common
 -Isrc/common -I../tor/src/ext/trunnel -I../tor/src/trunnel -I../tor/src/or
 -Isrc/or -DSHARE_DATADIR="\"/usr/share\"" -DLOCALSTATEDIR="\"/usr/var\""
 -DBINDIR="\"/usr/bin\"" -I../tor/src -DTOR_UNIT_TESTS -I../tor/src/common
 -I../UPSTREAM/usr/include -I../UPSTREAM/usr/include
 -I../UPSTREAM/usr/include   -g -O2 -Wno-error=redundant-decls
 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-all -Wstack-
 protector -fasynchronous-unwind-tables -Wall -fno-strict-aliasing
 -Waddress -Warray-bounds -Wdouble-promotion -Wextra -Winit-self -Wlogical-
 op -Wmissing-field-initializers -Wmissing-format-attribute -Wmissing-
 noreturn -Woverlength-strings -Woverride-init -Wshadow -Wsync-nand
 -Wtrampolines -Wunused-but-set-parameter -Wunused-but-set-variable
 -Wunused-local-typedefs -Wvariadic-macros -W -Wfloat-equal -Wundef
 -Wpointer-arith -Wstrict-prototypes -Wmissing-prototypes -Wwrite-strings
 -Wredundant-decls -Wchar-subscripts -Wcomment -Wformat=2 -Wwrite-strings
 -Wnested-externs -Wbad-function-cast -Wswitch-enum -Waggregate-return
 -Wpacked -Wunused -Wunused-parameter  -Wold-style-definition -Wmissing-
 declarations -Werror -MT src/or/src_or_libtor_testing_a-main.o -MD -MP -MF
 src/or/.deps/src_or_libtor_testing_a-main.Tpo -c -o src/or
 /src_or_libtor_testing_a-main.o `test -f 'src/or/main.c' || echo
 '../tor/'`src/or/main.c
 ../tor/src/or/main.c: In function 'tor_main':
 ../tor/src/or/main.c:3671:28: error: 'HeapEnableTerminationOnCorruption'
 undeclared (first use in this function)
 ../tor/src/or/main.c:3671:28: note: each undeclared identifier is reported
 only once for each function it appears in
 make[1]: *** [src/or/src_or_libtor_testing_a-main.o] Error 1
 }}}
 https://jenkins.torproject.org/job/tor-ci-windows-commit/1293/

 This part of the patch needs to be made conditional on the existence of
 the function.
 We must fix this or back out the change before the 0.3.1 release.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21953#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online