[tor-bugs] #21766 [Applications/Tor Browser]: Tor Browser based on ESR52 with e10s enabled crashed while trying to download a file

[Tor Bug Tracker & Wiki]

#21766: Tor Browser based on ESR52 with e10s enabled crashed while trying to
download a file
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  mcs
     Type:  defect                               |         Status:
                                                 |  assigned
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Critical                             |     Resolution:
 Keywords:  ff52-esr, tbb-e10s, tbb-crash,       |  Actual Points:
  TorBrowserTeam201705, tbb-7.0-must             |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor4
-------------------------------------------------+-------------------------

Comment (by mcs):

 Replying to [comment:30 arthuredelstein]:
 > Replying to [comment:22 mcs]:
 > > see ticket:21886#comment:16 for a patch that tries but fails to fix
 this problem.
 >
 > I cherry-picked this patch onto `tor-browser-52.1.1esr-7.0-1-build1`
 (`454a231f2b76a8857748d93f666bb93199f4b963`), built tor-browser.git, and
 added NoScript and torbutton. The patch worked for me (with e10s active)
 -- I saw the confirmation prompt and was able to cancel or download files
 on Linux. I used gdb to check the return values of Suspend() and Resume()
 and they both returned NS_OK.

 Interesting. Did you test with an optimized build or a debug build?

 I am creating a debug build now with the patch applied to the tip of tor-
 browser-52.1.1esr-7.0-1 (7bbd69956bd1a30051599a1dd4bf615bc40e55e8, aka
 tor-browser-52.1.1esr-7.0-1-build2). I want to be sure to test with the
 #22254 fix in place. But you must have fixed that manually?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21766#comment:31>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online