[tor-bugs] #22281 [Core Tor/Tor]: Prevent pattern of bugs caused by calling get_options() within options_validate() etc

Tue May 16 23:58:15 UTC 2017

#22281: Prevent pattern of bugs caused by calling get_options() within
options_validate() etc
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:
     Type:  defect        |         Status:  new
 Priority:  Medium        |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by arma):

 I had thought, as a short term hack, to assign the current options we're
 testing, if the global options is null, and also to add a boolean
 "in_validation", and then have get_options() warn when it returns an
 options set that has in_validation true. That would turn the current
 asserts into warns.

 I'm not sure if that hack fixes enough to be worthwhile though.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22281#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online