[tor-bugs] #7869 [Core Tor/Tor]: ntor-onion-key is padded with an equal sign

[Tor Bug Tracker & Wiki]

#7869: ntor-onion-key is padded with an equal sign
-------------------------------------------------+-------------------------
 Reporter:  rransom                              |          Owner:
                                                 |  Jigsaw52
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Low                                  |      Milestone:  Tor:
                                                 |  0.3.2.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-relay, easy, intro,              |  Actual Points:
  tor-03-unspecified-201612                      |
Parent ID:                                       |         Points:
 Reviewer:  catalyst                             |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by catalyst):

 I'm sorry, after I looked at the patch while more awake I realized that
 the NULs were to overwrite the `=` padding.  `base64_encode_nopad()` seems
 like it would be a better option, though.  I think it's kind of inelegant
 at the moment and requires that the destination buffer be large enough to
 hold the padded (and NUL-terminated) encoding, but using it here would
 eliminate some code duplication.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7869#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online