[tor-bugs] #22217 [Metrics/metrics-lib]: Parse new padding-counts lines
Tor Bug Tracker & Wiki
blackhole at torproject.org
Tue May 16 12:52:58 UTC 2017
#22217: Parse new padding-counts lines
---------------------------------+-----------------------------------
Reporter: karsten | Owner: karsten
Type: enhancement | Status: needs_review
Priority: Medium | Milestone: metrics-lib 1.7.0
Component: Metrics/metrics-lib | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
---------------------------------+-----------------------------------
Changes (by karsten):
* status: needs_revision => needs_review
Comment:
Replying to [comment:4 iwakeh]:
> Please find four commits in [https://gitweb.torproject.org/user/iwakeh
/metrics-lib.git/?h=task-22217 my repo branch].
Looks good. Merged into mine together with a few whitespaces fixes and
after prefixing instance method calls and references to instance variables
with `this.` to be consistent with the other code.
> Open topics I noticed in other parts of the code:
> The empty key issue seems to also apply to comma separated key-value
pairs and maybe others. Similarly repeated keys. New ticket?
I included a fix and tests for empty keys. I briefly pondered adding
checks and tests for duplicate keys, but I'd rather want to postpone that
discussion in order not to de-stabilize master this close to the release.
Maybe we can combine that with a minor code cleanup where we're
duplicating less of that parsing code. Want to create that new ticket?
> It would be good to add the check for the correct exception string also
to other test methods in ExtraInfoDescriptorTest. Another ticket?
Yes, new ticket sounds good. Mind creating one?
If you like [https://gitweb.torproject.org/user/karsten/metrics-
lib.git/log/?h=task-22217 these changes], I'll merge that branch into
master and start preparing the release. Thanks!
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22217#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list