[tor-bugs] #21654 [Core Tor/Tor]: Don't use fgets() when we might get EAGAIN

Tue May 16 02:22:38 UTC 2017

#21654: Don't use fgets() when we might get EAGAIN
-------------------------------+------------------------------------
 Reporter:  nickm              |          Owner:  ahf
     Type:  defect             |         Status:  closed
 Priority:  Medium             |      Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor       |        Version:
 Severity:  Normal             |     Resolution:  fixed
 Keywords:  TorCoreTeam201703  |  Actual Points:
Parent ID:                     |         Points:
 Reviewer:                     |        Sponsor:
-------------------------------+------------------------------------

Comment (by ahf):

 A test was added for the `EAGAIN` behaviour with `fgets()` on non-blocking
 I/O in commit `8ee559bd` on Fri Oct 8 21:31:15 2010.

 It seems the behaviour was mentioned during the code review by Nick in bug
 #1903 and also mentioned in #2045, so this have been an issue on and off
 since at least tor-0.2.3.1-alpha.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21654#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online