[tor-bugs] #21683 [Applications/Tor Browser]: Make sure safebrowsing is still disabled in ESR 52

[Tor Bug Tracker & Wiki]

#21683: Make sure safebrowsing is still disabled in ESR 52
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  task                                 |         Status:  closed
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Major                                |     Resolution:  fixed
 Keywords:  ff52-esr, tbb-proxy-bypass, tbb-7.0  |  Actual Points:
  -must-alpha, TorBrowserTeam201705R             |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor4
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:11 mcs]:
 > r=brade, r=mcs
 > Looks good to us. We also saw the following URL-based prefs but maybe
 they are only used for secondary queries?
 > {{{
 > browser.safebrowsing.provider.google.gethashURL
 > browser.safebrowsing.provider.google4.gethashURL
 > browser.safebrowsing.provider.mozilla.gethashURL
 > }}}
 I think so. But, however, I set them to `""` as well in commit
 e6b28367e061f9b6912c3b150383255bdff0ef5c `tor-browser-52.1.0esr-7.0-2` as
 this makes things more clear and doesn't hurt.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21683#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online