[tor-bugs] #21953 [Core Tor/Tor]: Dealing with Tor hardening on Windows properly

[Tor Bug Tracker & Wiki]

#21953: Dealing with Tor hardening on Windows properly
--------------------------+------------------------------------
 Reporter:  cypherpunks   |          Owner:
     Type:  defect        |         Status:  assigned
 Priority:  Medium        |      Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  030-backport  |  Actual Points:
Parent ID:                |         Points:  0.1
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by tom):

 I can review for Windows.

 Patch is good hygiene and worth taking, but it's not going to radically
 improve tor's security.

 As noted, HeapEnableTerminationOnCorruption is enabled by default in
 Win8+.

 PROCESS_DEP_DISABLE_ATL_THUNK_EMULATION I do not believe is needed because
 we're not using ATL library/framework stuff. But it's fine to have, and
 like I said, good hygiene.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21953#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online