[tor-bugs] #22177 [Core Tor/Tor]: CID 1405875 dead code in test_options_validate_impl() (was: Remove dead code in test_options_validate_impl())

[Tor Bug Tracker & Wiki]

#22177: CID 1405875 dead code in test_options_validate_impl()
--------------------------+------------------------------------
 Reporter:  ahf           |          Owner:  catalyst
     Type:  defect        |         Status:  closed
 Priority:  Medium        |      Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:  fixed
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Old description:

> Coverity found some dead code in CID 1405875, which we should fix.

New description:

 Coverity found some dead code in CID 1405875, which we should fix.  The
 dead code is to handle an error condition in `config_get_lines()`, which
 we weren't testing.  The short-term fix is to remove the offending code,
 and a longer-term fix is to actually test the relevant error conditions so
 that the dead code would execute.

--

Comment (by catalyst):

 Updated description.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22177#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online